-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added install requirements to setup #488
Added install requirements to setup #488
Conversation
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
Thanks for this contribution! When working with @Titus-von-Koeller @younesbelkada, what is your opinion? |
@TimDettmers If I may chip in, that shouldn't be an issue here – there is no version requirement here, so any version of That said, There's also an argument for not requiring Scipy by default: #948 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not good to hard-require pandas and matplotlib.
Co-authored-by: Aarni Koskela <[email protected]>
@TimDettmers Pip may install a different pytorch version if another package installed in the same virtual environement as bitsandbyte require (strictly) a different version. Otherwise, since the requirement is On HPC systems where administrators maintains a wheelhouse, or to simply avoid user issues when installing/using packages, it is easier to have the main package request its dependencies. As for |
You're right, the build part of bnb might see overhauls soon, but I don't see any reason not to merge this. Makes sense. Thanks for your contribution, really appreciated 🤗 |
When installing or distributing, ensure needed requirements are present.