-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a dockerized service for print_label_service.py #168
base: master
Are you sure you want to change the base?
Conversation
one question answered: the docker host is specified in the inventory file. |
hvilken som helst maskin på bitraf lan med docker og docker-compose burde kunne teste dette med (kanskje først noe mer) |
en feil jeg oppdaget på den måten:
|
|
er det en spesiell grunn til at du ikke vil kjøre programmet som root inni kontaineren? |
I would suggest that the bitraf-iot repository takes care of producing the docker image and that this repository just installs that image. This would be similar to what we do with p2k16, postgresql and the other images. The p2k16 repository has its own docker-compose.yml for local testing of the image. I see now that that docker-compose actually doesn't include a p2k16 service, but it could :). |
ikke noe annet enn at det er "best practice" å kjøre som en annen bruker enn root. |
ok. jeg ser det er gjort sånn i p2k16 sin Dockerfile også, men riktig :) https://github.com/bitraf/p2k16/blob/master/docker/Dockerfile |
(altså |
Det riktige i dette tilfellet hadde vel bare vært chmod a+r. I p2k16 så kjøres pip install som p2k16 som peller på filene i imaget. P2k16 skulle ideelt sett delt opp bygging og kjøring i to images, men jeg har ikke orket enda. |
ok, this is now working, and ready for review. Fixes bitraf/bitraf-iot#19. |
See also #125 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after a quick read!
My attempt at fixing bitraf/bitraf-iot#19 Very much a work in progress. I have some questions: