Fixes a bug when the IPN/webhook is received with "complete" status. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "complete" IPN message was coming through this code would throw a RuntimeException with "Wrong BitPay status..." message, this is because this code was looking for a status "completed" instead of "complete". Possibly the original developer might have gotten mixed up because Woocommerce order status is named "completed" but the BitPay invoice status is named "complete" which is very similar.
|
This is fantastic @shaunek-hero , thank you so much! We'll test this out in the morning and prep version 5.3.2 for release. |
mwarzybok-sumoheavy
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "complete" IPN message was coming through this code would throw a RuntimeException with "Wrong BitPay status..." message, this is because this code was looking for a status "completed" instead of "complete".
Possibly the original developer might have gotten mixed up because Woocommerce order status is named "completed" but the BitPay invoice status is named "complete" which is very similar.