Handle non-yospace id3tags gracefully #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5fc19b3)
This fixes an issue with ads not being properly deactivated when seeked past
Remove Yospace SDK from `peerDependencies` (it is part of `dependencies`). Remove Bitmovin Player from `dependencies` (it is part of `peerDependencies`).
…he library by accessing code (like enums) directly from it
…ess the site is in validation mode)
…-yospace-id3tags-gracefully Conflicts: package-lock.json package.json src/ts/BitmovinYospacePlayerAPI.ts
…s-gracefully Conflicts: CHANGELOG.md src/ts/InternalBitmovinYospacePlayer.ts
…-yospace-id3tags-gracefully Conflicts: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The integration tried to parse non-yospace ID3 tags, and passed them to the yospace SDK, which led to errors in the console. This PR stops doing that. If an ID3 tag doesn't have the standard yospace tags the SDK expects, the ID3 tag will be discarded.
This is based on #171 and should be merged after that PR.
Checklist (for PR submitter and reviewers)
CHANGELOGentry