Merge pull request #178 from bitmovin/feature/fix-load-error-promise-…

…rejection-reason Fix load error promise rejection reason
bitmovin · Oct 3, 2024 · c0ef5ad · c0ef5ad
2 parents d467053 + 1d01d4b
commit c0ef5ad
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+### Fixed
+
+- Yospace error on source load and session initialization not returned in `load` promise rejection as reason
+
 ## [2.7.0] - 2024-09-27
 
 ### Added

diff --git a/src/ts/InternalBitmovinYospacePlayer.ts b/src/ts/InternalBitmovinYospacePlayer.ts
@@ -17,6 +17,7 @@ import {
   TimedMetadata,
   UNKNOWN_FORMAT,
   YoLog,
+  DebugFlags,
 } from '@yospace/admanagement-sdk';
 
 import type {
@@ -195,8 +196,9 @@ export class InternalBitmovinYospacePlayer implements BitmovinYospacePlayerAPI {
     return new Promise<void>((resolve, reject) => {
       if (!source.hls && !source.dash) {
         this.resetState();
-        this.handleYospaceError(new YospacePlayerError(YospaceErrorCode.SUPPORTED_SOURCE_MISSING));
-        reject();
+        const yospaceError = new YospacePlayerError(YospaceErrorCode.SUPPORTED_SOURCE_MISSING);
+        this.handleYospaceError(yospaceError);
+        reject(yospaceError);
         return;
       }
       this.resetState();
@@ -285,16 +287,17 @@ export class InternalBitmovinYospacePlayer implements BitmovinYospacePlayerAPI {
           session.shutdown();
           this.session = null;
 
-          this.handleYospaceError(getYospaceError());
-          reject();
+          const yospaceError = getYospaceError();
+          this.handleYospaceError(yospaceError);
+          reject(yospaceError);
         }
       };
 
       const properties = new SessionProperties();
       properties.setUserAgent(navigator.userAgent);
 
       if (this.yospaceConfig.debug || this.yospaceConfig.debugYospaceSdk) {
-        YoLog.setDebugFlags(DEBUG_ALL);
+        YoLog.setDebugFlags(DebugFlags.DEBUG_ALL);
       }
 
       switch (source.assetType) {