Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id to sections for linking in Demos page of Platform website (#10253) #10256

Conversation

msynk
Copy link
Member

@msynk msynk commented Mar 14, 2025

closes #10253

Summary by CodeRabbit

  • Style
    • Enhanced text display components with identifiers and scroll spacing to improve in-page navigation and visual consistency.
  • Bug Fixes
    • Refined navigation highlighting to ensure more accurate active state detection when browsing.

@msynk msynk requested a review from ysmoradi March 14, 2025 17:48
Copy link

coderabbitai bot commented Mar 14, 2025

Walkthrough

The changes involve updates to two files. One file, a Razor page, now assigns specific id attributes and a scroll-margin-top:100px style to several <BitText> components. The other file, a code-behind for the main layout, refines the URL matching logic by adding a leading slash to substring checks in the navigation item setup.

Changes

File(s) Summary
src/.../Pages/DemosPage.razor Added id attributes and a Style="scroll-margin-top:100px" property to multiple <BitText> components for sections such as "boilerplate", "adminpanel", "sales", "todo", "platform", and "blazorui".
src/.../Shared/MainLayout.razor.cs Updated the SetNavItems method to check URL substrings with a leading slash (e.g., /templates instead of templates) for refined route matching.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MainLayout
    participant URLChecker as URL Checker Logic
    User->>MainLayout: Request page load
    MainLayout->>URLChecker: Execute SetNavItems (assess current URL)
    URLChecker-->>MainLayout: Return route flags (with updated slash checks)
    MainLayout->>User: Render navigation based on route flags
Loading

Poem

Hi, I'm a rabbit hopping in code,
IDs and styles now neatly bestowed.
Routes are checked with a slash so clear,
In my digital warren, there's nothing to fear.
Leaping through changes with a happy cheer!
🥕🐇

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ace8bec and 8307b72.

📒 Files selected for processing (2)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/DemosPage.razor (6 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Shared/MainLayout.razor.cs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build and test
🔇 Additional comments (3)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Shared/MainLayout.razor.cs (1)

101-105: Improved URL matching with leading slashes

The changes to add leading slashes to the URL checks make the routing logic more precise, ensuring that only explicit routes (not substrings within other paths) will match. This prevents false positives like /my-templates-page incorrectly matching the templates check in the previous implementation.

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/DemosPage.razor (2)

53-53: Well-implemented section identifier with proper scrolling behavior

Adding both the id attribute and scroll-margin-top property is a great implementation. The ID enables direct linking to this section, while the scroll margin ensures the heading isn't hidden under any fixed headers when navigated to via anchor links.


80-80: Consistent implementation across all section headings

The same pattern has been consistently applied to all section headings, creating a uniform navigation experience throughout the page. This implementation satisfies the PR objective of "adding unique identifiers to various sections for direct linking."

Also applies to: 99-99, 117-117, 136-136, 152-152

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msynk msynk merged commit a57f65f into bitfoundation:develop Mar 14, 2025
3 checks passed
@msynk msynk deleted the 10253-websites-platform-demospage-sections-link branch March 14, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The DemosPage of the Platform website needs links to each demo samples presented on it
1 participant