Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix after first render issues of BitCarousel (#10252) #10255

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Fix after first render issues of BitCarousel (#10252) #10255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions src/BlazorUI/Bit.BlazorUI/Components/Lists/Carousel/BitCarousel.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,19 @@ protected override void OnParametersSet()

protected override async Task OnAfterRenderAsync(bool firstRender)
{
await base.OnAfterRenderAsync(firstRender);
if (firstRender)
{
await _js.BitObserversRegisterResize(UniqueId, RootElement, _dotnetObj);

if (ScrollItemsCount > VisibleItemsCount)
{
_internalScrollItemsCount = VisibleItemsCount;
}

await ResetDimensionsAsync();

await _pageVisibility.Init();
}

_directionStyle = Dir == BitDir.Rtl ? "direction:rtl" : string.Empty;

Expand All @@ -228,18 +240,7 @@ protected override async Task OnAfterRenderAsync(bool firstRender)
_autoPlayTimer = null;
}

if (firstRender is false) return;

await _pageVisibility.Init();

await _js.BitObserversRegisterResize(UniqueId, RootElement, _dotnetObj);

if (ScrollItemsCount > VisibleItemsCount)
{
_internalScrollItemsCount = VisibleItemsCount;
}

await ResetDimensionsAsync();
await base.OnAfterRenderAsync(firstRender);
}


Expand Down
36 changes: 24 additions & 12 deletions src/BlazorUI/Bit.BlazorUI/Scripts/Observers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,36 @@
private static _resizeObservers: Record<string, ResizeObserver> = {};

public static registerResize(id: string, element: HTMLElement, obj: DotNetObject) {
const observer = new ResizeObserver(entries => {
const entry = entries[0];
if (!entry) return;
if (!element || !(element instanceof Element)) return;

obj.invokeMethodAsync("OnResize", entry.contentRect);
});
observer.observe(element);
try {
const observer = new ResizeObserver(entries => {
const entry = entries[0];
if (!entry) return;

Observers._resizeObservers[id] = observer;
obj.invokeMethodAsync("OnResize", entry.contentRect);
});
observer.observe(element);

Observers._resizeObservers[id] = observer;
} catch (err) {
console.error(err);
}
}

public static unregisterResize(id: string, element: HTMLElement, obj: DotNetObject) {
const observer = Observers._resizeObservers[id];
if (!observer) return;
if (!element || !(element instanceof Element)) return;

try {
const observer = Observers._resizeObservers[id];
if (!observer) return;

observer.unobserve(element);
delete Observers._resizeObservers[id];
obj.dispose();
observer.unobserve(element);
delete Observers._resizeObservers[id];
obj.dispose();
} catch (err) {
console.error(err);
}
}
}
}
Loading