Remove remaining usages of BitSpinButton (#10249) #10254
Conversation
WalkthroughThe changes remove references to the SpinButton component and update numeric input controls. In the BlazorUI demo, the "SpinButton" entry was removed from the Changes
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Components/DemoPage.razor.cs(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/compilerconfig.json(0 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil09StoragePage.razor(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil09StoragePage.razor.cs(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil11HistoryPage.razor(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil11HistoryPage.razor.cs(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil12ElementPage.razor(3 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil12ElementPage.razor.cs(3 hunks)
💤 Files with no reviewable changes (1)
- src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/compilerconfig.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build and test
🔇 Additional comments (12)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil09StoragePage.razor.cs (1)
96-96: Component replaced correctly.The
BitSpinButtoncomponent has been correctly replaced withBitNumberFieldfor thekeyIndexinput in the example code.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Components/DemoPage.razor.cs (1)
166-166: SpinButton component entry successfully removed.The "SpinButton" entry has been properly removed from the
_inputComponentslist, which aligns with the PR's objective to remove remaining usages of BitSpinButton.src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil11HistoryPage.razor.cs (1)
87-87:✅ Verification successful
Component replaced but mode attribute may need updating.
The
BitSpinButtonhas been replaced withBitNumberField, but theMode="BitSpinButtonMode.Inline"attribute is still referencing theBitSpinButtonModeenum, which may be incorrect if this enum is specific to the removed component.
🏁 Script executed:
#!/bin/bash # Check if BitSpinButtonMode is still used by BitNumberField rg "BitNumberField.*Mode=\"BitSpinButtonMode" -A2 -B2 # Check for the definition of BitSpinButtonMode to see if it's shared rg "enum BitSpinButtonMode" -A5 -B1Length of output: 15307
Component mode attribute is valid and intentional.
The BitNumberField component consistently uses the BitSpinButtonMode enum—including its Inline option—as documented by similar usages across pages (e.g., Butil12ElementPage, Butil09StoragePage, etc.). The existing enum definition confirms that BitSpinButtonMode is still active and supports the Inline mode. No update is necessary in this case.src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil12ElementPage.razor (5)
303-303: LGTM: BitSpinButton replaced with BitNumberField for scrollY.The replacement of BitSpinButton with BitNumberField while maintaining the Mode property ensures consistent behavior.
305-305: LGTM: BitSpinButton replaced with BitNumberField for scrollX.The replacement of BitSpinButton with BitNumberField while maintaining the Mode property ensures consistent behavior.
344-344: LGTM: BitSpinButton replaced with BitNumberField for scrollByY.The replacement of BitSpinButton with BitNumberField while maintaining the Mode property ensures consistent behavior.
346-346: LGTM: BitSpinButton replaced with BitNumberField for scrollByX.The replacement of BitSpinButton with BitNumberField while maintaining the Mode property ensures consistent behavior.
1205-1205: LGTM: BitSpinButton replaced with BitNumberField for newTabIndex.The replacement of BitSpinButton with BitNumberField while maintaining the Mode property ensures consistent behavior.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil12ElementPage.razor.cs (3)
645-647: LGTM: Updated code example with BitNumberField for scrollY and scrollX.The code examples have been correctly updated to use BitNumberField instead of BitSpinButton while maintaining the Mode property.
689-691: LGTM: Updated code example with BitNumberField for scrollByY and scrollByX.The code examples have been correctly updated to use BitNumberField instead of BitSpinButton while maintaining the Mode property.
1461-1461: LGTM: Updated code example with BitNumberField for newTabIndex.The code example has been correctly updated to use BitNumberField instead of BitSpinButton while maintaining the Mode property.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil09StoragePage.razor (1)
75-75: LGTM: BitSpinButton replaced with BitNumberField for keyIndex.The replacement of BitSpinButton with BitNumberField while maintaining the Mode property ensures consistent behavior. The Min attribute has also been properly preserved.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Butil/Butil11HistoryPage.razor
Show resolved
Hide resolved
closes #10249
Summary by CodeRabbit