social signed-in user assumed as confirmed user (#10239)

[ysmoradi]

closes #10239

Summary by CodeRabbit

• New Features
  • Enhanced social sign-in: Your full name is now automatically captured when signing in with a social account, ensuring a more personalized profile.
  • Improved account confirmation: The verification process has been refined to include additional criteria for a more robust and secure account setup.

[coderabbitai]

Walkthrough

This pull request modifies two aspects of the identity handling. In the social sign-in callback, a new variable is introduced to extract the user's name from their claims and initialize the user object with both the full name and lockout settings. In the user confirmation process, the method now checks for associated logins in addition to verifying email or phone confirmation, thereby updating the control flow for confirming a user.

Changes

File	Change Summary
src/Templates/…/Controllers/Identity/IdentityController.SocialSignIn.cs	In the SocialSignInCallback method, added a variable to extract the user's name from claims and set the FullName property during user instantiation, along with LockoutEnabled.
src/Templates/…/Services/Identity/AppUserConfirmation.cs	Updated IsConfirmedAsync to additionally check for associated logins by calling manager.GetLoginsAsync(user), expanding the user confirmation criteria.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant IdentityController
    participant UserObject
    Client->>IdentityController: SocialSignInCallback(info)
    IdentityController->>IdentityController: Extract 'name' from info.Principal claims
    IdentityController->>UserObject: Instantiate user (FullName = name, LockoutEnabled = true)
    IdentityController->>Client: Return response

Loading

sequenceDiagram
    participant Caller
    participant AppUserConfirmation
    participant UserManager
    participant User
    Caller->>AppUserConfirmation: Request confirmation check
    AppUserConfirmation->>UserManager: Call GetLoginsAsync(user)
    UserManager-->>AppUserConfirmation: Return logins list
    AppUserConfirmation->>AppUserConfirmation: Evaluate email/phone confirmation OR logins present
    AppUserConfirmation->>Caller: Return boolean result

Loading

Poem

I'm a bouncy rabbit in the code land delight,
Adding names and logins with all my might.
Claims turn to full names with a hop and a spin,
Confirmations now check logins to win.
With each gentle tweak, I dance in the byte,
Celebrating fresh changes under the moonlight.
🐇💻 Hop, hop, hooray!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3d3baf and 70cbe5b.

📒 Files selected for processing (2)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.SocialSignIn.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Services/Identity/AppUserConfirmation.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (2)

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.SocialSignIn.cs (1)

53-60: LGTM - Good improvement for user experience

Adding the user's name from their social login claims enhances the user creation process, providing a better initial profile setup for users signing in through social providers.

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Services/Identity/AppUserConfirmation.cs (1)

9-11: Correctly assumes social signed-in users as confirmed users

This change fulfills the PR objective by considering users with associated social logins as confirmed, which is a common practice since social authentication providers have already verified these users. This eliminates the need for additional email/phone verification steps for social users.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.