Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add store scroll feature to BitAppShell (#10233) #10234

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Add store scroll feature to BitAppShell (#10233) #10234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6723b0c
add store scroll feature to BitAppShell #10233
msynk Mar 13, 2025
1dd375b
add missing route
msynk Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/BlazorUI/Bit.BlazorUI.Extras/Components/AppShell/BitAppShell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
namespace BitBlazorUI {
export class AppShell {
private static STORE_KEY = 'bit-appshell-scrolls';

public static PreScroll: number = 0;

private static _currentUrl: string;
Expand All @@ -9,9 +11,10 @@ namespace BitBlazorUI {
public static initScroll(container: HTMLElement, url: string) {
AppShell._container = container;
AppShell._currentUrl = url;
AppShell._scrolls[url] = AppShell.PreScroll;
if (AppShell.PreScroll > 0) {
AppShell._container.scrollTo({ top: AppShell.PreScroll, behavior: 'instant' });
AppShell._scrolls = JSON.parse(sessionStorage.getItem(AppShell.STORE_KEY) || '{}');
AppShell.storeScroll(url, AppShell.PreScroll > 0 ? AppShell.PreScroll : AppShell._scrolls[url]);
if (AppShell._scrolls[url]! > 0) {
AppShell._container.scrollTo({ top: AppShell._scrolls[url], behavior: 'instant' });
}
AppShell.addScroll();
}
Expand All @@ -22,7 +25,7 @@ namespace BitBlazorUI {

public static afterRenderScroll(url: string) {
AppShell._currentUrl = url;
AppShell._scrolls[url] = AppShell._scrolls[url] || 0;
AppShell.storeScroll(url, AppShell._scrolls[url]);
AppShell._container?.scrollTo({ top: AppShell._scrolls[url], behavior: 'instant' });
AppShell.addScroll();
}
Expand All @@ -40,7 +43,12 @@ namespace BitBlazorUI {
}

private static onScroll() {
AppShell._scrolls[AppShell._currentUrl] = AppShell._container?.scrollTop;
AppShell.storeScroll(AppShell._currentUrl, AppShell._container?.scrollTop);
}

private static storeScroll(url: string, value: number | undefined) {
AppShell._scrolls[url] = value || 0;
window.sessionStorage.setItem(AppShell.STORE_KEY, JSON.stringify(AppShell._scrolls));
}
}
}
Expand Down
1 change: 1 addition & 0 deletions src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/OverviewPage.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@page "/overview"
@page "/components"

<PageOutlet Url="overview"
Title="Overview"
Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Shared/MainLayout.razor.NavItems.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ public partial class MainLayout

private readonly List<BitNavItem> _navItems =
[
new() { Text = "Overview", Url = "/overview" },
new() { Text = "Overview", Url = "/overview", AdditionalUrls = ["/components"] },
new() { Text = "Getting started", Url = "/getting-started" },
new()
{
Expand Down
Loading