Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all tsconfig files to add target property across all projects (#10217) #10218

Merged

Conversation

msynk
Copy link
Member

@msynk msynk commented Mar 9, 2025

closes #10217

Summary by CodeRabbit

  • Chores
    • Upgraded build configuration targets to utilize modern JavaScript standards, enhancing compatibility and access to newer language features.
    • Reorganized configuration options for a more consistent and streamlined development process.

@msynk msynk requested a review from ysmoradi March 9, 2025 17:48
Copy link

coderabbitai bot commented Mar 9, 2025

Walkthrough

Multiple TypeScript configuration files have been modified across the project. Most changes add a new "target" property under compilerOptions to specify ECMAScript versions—either "ES2019" or "ES2022"—for the compiled JavaScript. One file updates its existing target from "es6" to "ES2019", and another reorders configuration options by moving the "outFile" setting. These updates ensure that the compilation output adheres to the desired ECMAScript standards.

Changes

File(s) Change Summary
src/BlazorUI/Bit.BlazorUI.Extras/tsconfig.json
src/BlazorUI/Bit.BlazorUI/tsconfig.json
src/Bup/Bit.Bup/tsconfig.json
src/Templates/.../Boilerplate.Client.Core/tsconfig.json
Added "target": "ES2019" in compilerOptions.
src/Bswup/Bit.Bswup/tsconfig.json Updated "target" from "es6" to "ES2019" in compilerOptions.
src/BlazorUI/Demo/.../tsconfig.json
src/Websites/Careers/.../tsconfig.json
src/Websites/Platform/.../tsconfig.json
src/Websites/Sales/.../tsconfig.json
Added "target": "ES2022" in compilerOptions.
src/Butil/Bit.Butil/tsconfig.json Added "target": "ES2019" and moved "outFile": "wwwroot/bit-butil.js" within compilerOptions.

Poem

I'm a bunny in the code burrow, full of cheer,
Hopping through tsconfig files, now perfectly clear.
ES2019 and ES2022 shine like stars at night,
With targets set just right, my heart feels light.
Carrots and code—today, the future's bright!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d9a83c and 3d05307.

📒 Files selected for processing (10)
  • src/BlazorUI/Bit.BlazorUI.Extras/tsconfig.json (1 hunks)
  • src/BlazorUI/Bit.BlazorUI/tsconfig.json (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/tsconfig.json (1 hunks)
  • src/Bswup/Bit.Bswup/tsconfig.json (1 hunks)
  • src/Bup/Bit.Bup/tsconfig.json (1 hunks)
  • src/Butil/Bit.Butil/tsconfig.json (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/tsconfig.json (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Client/tsconfig.json (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/tsconfig.json (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Client/tsconfig.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build and test
🔇 Additional comments (10)
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/tsconfig.json (1)

5-5: ECMAScript target set to ES2019.
The addition of the "target": "ES2019" property is consistent with the PR objectives and ensures that the TypeScript compiler generates JavaScript according to ECMAScript 2019 standards.

src/Bswup/Bit.Bswup/tsconfig.json (1)

5-5: Updated target from es6 to ES2019.
Changing the target from "es6" to "ES2019" aligns this configuration with the broader project standard, improving consistency across TS projects.

src/BlazorUI/Bit.BlazorUI/tsconfig.json (1)

5-5: Added target property with ES2019.
Introducing "target": "ES2019" in the compiler options ensures that the output adheres to the ECMAScript 2019 standard, supporting more modern language features as intended by the PR.

src/Bup/Bit.Bup/tsconfig.json (1)

5-5: Consistent ECMAScript target applied.
The addition of "target": "ES2019" in this configuration ensures consistency with other projects and meets the PR’s standardization goals.

src/BlazorUI/Bit.BlazorUI.Extras/tsconfig.json (1)

5-5: ECMAScript target property correctly set.
Setting "target": "ES2019" here matches the configuration across multiple modules, thereby providing unified transpilation settings and fulfilling the PR objective.

src/Butil/Bit.Butil/tsconfig.json (1)

5-7: Verify and Document ECMAScript Version Choice

The new "target": "ES2019" property, along with the reordered "outFile" setting, appears correct. However, note that while this project now targets ES2019, several other projects in the repo are updated to target ES2022. Please confirm that this version difference is intentional based on project requirements.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/tsconfig.json (1)

4-8: Adoption of ES2022 for Client Core

The addition of "target": "ES2022" within the compilerOptions ensures the output leverages modern ECMAScript features. Given the strict compiler settings in place, please verify that this target version is supported by all relevant build and runtime environments.

src/Websites/Sales/src/Bit.Websites.Sales.Client/tsconfig.json (1)

3-9: Modern Compilation Target for Sales Client

By introducing "target": "ES2022", this configuration updates the JavaScript output to a more modern standard. This change is beneficial for utilizing newer language features. Please ensure that the ES2022 target aligns with the application’s compatibility requirements and that any potential side effects on legacy code have been considered.

src/Websites/Careers/src/Bit.Websites.Careers.Client/tsconfig.json (1)

3-9: Ensuring Compatibility with ES2022

The addition of "target": "ES2022" helps modernize the compilation output for the Careers client. Confirm that this update is consistent with the expectations for this project and that no legacy dependencies are negatively impacted by the ES2022 features.

src/Websites/Platform/src/Bit.Websites.Platform.Client/tsconfig.json (1)

3-9: Alignment with Modern JavaScript Standards

The updated configuration now includes "target": "ES2022", which should enable the use of ES2022 features in the output. Please verify that this setting is harmonized with the deployment environments and that any integrations with other projects (which might target a different ECMAScript version) are intentionally configured.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msynk msynk merged commit fbcdbb2 into bitfoundation:develop Mar 9, 2025
3 checks passed
@msynk msynk deleted the 10217-infra-tsconfig-target-es2019 branch March 9, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The target property of all tsconfig.json files should be present across all projects
1 participant