Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Boilerplate push notification subscription (#10212) #10213

Merged
merged 3 commits into from
Mar 9, 2025

Conversation

ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Mar 8, 2025

closes #10212

Summary by CodeRabbit

  • New Features
    • Introduced a controlled delay for push notifications on first launch for a smoother initialization process.
    • Enhanced online status detection during pre-rendering to provide more accurate connectivity feedback.
  • Bug Fixes
    • Revised the navigation on the product editing page so that the button now correctly leads to the products page.

@ysmoradi ysmoradi requested a review from msynk March 8, 2025 20:24
Copy link

coderabbitai bot commented Mar 8, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update several components across the project. In the client coordinator, a method is renamed from handling a user ID to managing authentication state, and a delay has been introduced for push notification subscription on first run. The main layout now injects a JavaScript runtime dependency and checks pre-render conditions to adjust the online status. Finally, a navigation adjustment in the products page redirects the button from the categories page to the products page.

Changes

File Change Summary
src/Templates/Boilerplate/Bit.Boilerplate/.../Components/ClientAppCoordinator.cs Renamed method PropagateUserId to PropagateAuthState and added a conditional block with a 10-second delay for push notifications subscription when firstRun is true.
src/Templates/Boilerplate/Bit.Boilerplate/.../Components/Layout/MainLayout.razor.cs Introduced dependency injection for IJSRuntime and updated initialization logic to check pre-render status for setting the isOnline value.
src/Templates/Boilerplate/Bit.Boilerplate/.../Components/Pages/Authorized/Products/AddOrEditProductPage.razor Updated the Href attribute from pointing to the Categories page to the Products page.

Sequence Diagram(s)

sequenceDiagram
    participant App as ClientAppCoordinator
    participant Auth as AuthenticationState
    participant PNS as PushNotificationService
    App->>Auth: Receive authentication state task
    alt firstRun is true
        App->>App: Delay 10 seconds
        App->>PNS: Subscribe to push notifications
    else
        App->>PNS: Proceed without delay
    end
Loading
sequenceDiagram
    participant Main as MainLayout
    participant JS as IJSRuntime
    participant Service as PrerenderStateService
    Main->>JS: Check initialization status
    Main->>Service: Get prerender state (inPrerenderSession)
    Service-->>Main: Return isOnline value
    Main->>Main: Update isOnline variable
Loading

Poem

Hop, hop, my code does gleam,
Renamed methods and delays like a dream.
With JS injected to guide the way,
The pages and buttons now play.
A rabbit of code, I cheer with delight,
Celebrating changes that leap into the night! 🥕🐇


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ysmoradi ysmoradi marked this pull request as ready for review March 9, 2025 10:07
@msynk msynk merged commit 1a81922 into bitfoundation:develop Mar 9, 2025
6 checks passed
@ysmoradi ysmoradi deleted the 10212 branch March 9, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boilerplate project template's push notification subscription needs improvements
2 participants