-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Boilerplate push notification subscription (#10212) #10213
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes update several components across the project. In the client coordinator, a method is renamed from handling a user ID to managing authentication state, and a delay has been introduced for push notification subscription on first run. The main layout now injects a JavaScript runtime dependency and checks pre-render conditions to adjust the online status. Finally, a navigation adjustment in the products page redirects the button from the categories page to the products page. Changes
Sequence Diagram(s)sequenceDiagram
participant App as ClientAppCoordinator
participant Auth as AuthenticationState
participant PNS as PushNotificationService
App->>Auth: Receive authentication state task
alt firstRun is true
App->>App: Delay 10 seconds
App->>PNS: Subscribe to push notifications
else
App->>PNS: Proceed without delay
end
sequenceDiagram
participant Main as MainLayout
participant JS as IJSRuntime
participant Service as PrerenderStateService
Main->>JS: Check initialization status
Main->>Service: Get prerender state (inPrerenderSession)
Service-->>Main: Return isOnline value
Main->>Main: Update isOnline variable
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
closes #10212
Summary by CodeRabbit