Fix bit Besql issue with lock during in-app migration (#10204)

[ysmoradi]

closes #10204

Summary by CodeRabbit

• Refactor
  • Enhanced the database context configuration to enable dynamic behavior based on the runtime environment, resulting in improved compatibility and service management.

[coderabbitai]

Walkthrough

The changes modify the AddBesqlDbContextFactory method in the IServiceCollectionBesqlExtentions class. Instead of passing the optionsAction directly to AddDbContextFactory, the implementation now wraps it in a lambda function. This lambda accepts a serviceProvider and options, applies conditional compilation logic for .NET 9.0 or later (to replace the service for IHistoryRepository with BesqlHistoryRepository), and then invokes the original optionsAction. The method signature remains unchanged, though the internal logic is updated.

Changes

File(s)	Change Summary
src/Besql/.../IServiceCollectionBesqlExtentions.cs	Modified AddBesqlDbContextFactory implementation to wrap optionsAction in a lambda that conditionally replaces IHistoryRepository with BesqlHistoryRepository for .NET 9.0 or above, then invokes the original delegate.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Application
    participant Ext as IServiceCollectionBesqlExtentions.AddBesqlDbContextFactory
    participant Factory as AddDbContextFactory (Lambda)
    participant Provider as serviceProvider
    participant Options as DbContextOptionsBuilder

    Client->>Ext: Call AddBesqlDbContextFactory(optionsAction)
    Ext->>Factory: Pass lambda (serviceProvider, options)
    Factory->>Factory: Check .NET version conditional
    alt .NET 9.0 or later
        Factory->>Factory: Replace IHistoryRepository with BesqlHistoryRepository
    end
    Factory->>Options: Invoke original optionsAction(serviceProvider, options)
    Options-->>Factory: Return configured options
    Factory-->>Ext: Continue with setup
    Ext-->>Client: Return IServiceCollection

Loading

Poem

"Hop along, now code's refined,
With lambda hops, a change designed,
Conditional branches, neat and bright,
I replace and tweak in the moonlit night,
A little tweak from a curious bunny's mind 🐰,
CodeRabbit sings—a change aligned!"

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf597c3 and 7833ead.

📒 Files selected for processing (1)

• src/Besql/Bit.Besql/IServiceCollectionBesqlExtentions.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (1)

src/Besql/Bit.Besql/IServiceCollectionBesqlExtentions.cs (1)

55-61: Good implementation to resolve the locking issue during migrations

This change consistently applies the BesqlHistoryRepository replacement to non-browser environments, matching what was already implemented for browser environments. By wrapping the options configuration in a lambda and replacing the standard IHistoryRepository with a custom implementation, this should help resolve the locking issues during in-app migrations referenced in issue #10204.

The approach is clean and maintains consistency with the existing pattern used in the browser environment code path.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.