Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bit BlazorUI source generator's SetParametersAsync generator (#10206) #10207

Merged
merged 6 commits into from
Mar 8, 2025
Merged

Improve bit BlazorUI source generator's SetParametersAsync generator (#10206) #10207

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efdd1e7
improve bit BlazorUI source generator's SetParametersAsync generator …
ysmoradi Mar 8, 2025
c812d90
fix
ysmoradi Mar 8, 2025
d071f46
Merge branch 'bitfoundation:develop' into 10206
ysmoradi Mar 8, 2025
4acac90
fix
ysmoradi Mar 8, 2025
368a8e0
fix
ysmoradi Mar 8, 2025
f970a96
fix
ysmoradi Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/BlazorUI/Bit.BlazorUI.SourceGenerators/Component/ComponentSourceGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,9 @@ public override Task SetParametersAsync(ParameterView parameters)
{
builder.AppendLine($" {par.PropertySymbol.Name}HasBeenSet = false;");
}
builder.AppendLine(" var parametersDictionary = parameters.ToDictionary() as Dictionary<string, object>;");
builder.AppendLine(" foreach (var parameter in parametersDictionary!)");
builder.AppendLine(" foreach (var parameter in parameters)");
builder.AppendLine(" {");
builder.AppendLine(" switch (parameter.Key)");
builder.AppendLine(" switch (parameter.Name)");
builder.AppendLine(" {");
foreach (var par in parameters)
{
Expand Down Expand Up @@ -96,7 +95,6 @@ public override Task SetParametersAsync(ParameterView parameters)
{
builder.AppendLine($" if (notEquals{paramName}) {par.CallOnSetMethodName}();");
}
builder.AppendLine(" parametersDictionary.Remove(parameter.Key);");
builder.AppendLine(" break;");
if (par.IsTwoWayBound)
{
Expand All @@ -105,7 +103,6 @@ public override Task SetParametersAsync(ParameterView parameters)
builder.AppendLine($" case nameof({paramName}):");
builder.AppendLine($" var {varName} = parameter.Value is null ? default! : (EventCallback<{sym.Type.ToDisplayString()}>)parameter.Value;");
builder.AppendLine($" {paramName} = {varName};");
builder.AppendLine(" parametersDictionary.Remove(parameter.Key);");
builder.AppendLine(" break;");
}
}
Expand All @@ -117,7 +114,7 @@ public override Task SetParametersAsync(ParameterView parameters)
}
else
{
builder.AppendLine(" return base.SetParametersAsync(ParameterView.FromDictionary(parametersDictionary as IDictionary<string, object?>));");
builder.AppendLine(" return base.SetParametersAsync(parameters);");
}
builder.AppendLine(@" }");

Expand Down
Loading