feat: add 'Conditionalise existing feedbacks' feedback #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
force-pushed
the
feat/conditional-advanced-feedbacks
branch
from
49d14fe to
2ffa9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the work from #2947 so that it can be used in combination with 'advanced' feedbacks from modules.
Resolves #2800
This is a semi hardcoded to there being 'children' and 'advancedChildren' for internal feedbacks, with other parts of the implementation being generic. I don't feel like this is worth unifying into a truely generic implementation at this time, most of the effort in doing so is the execution (which has to be specific to this feedback) and fixing up existing configs (as that would require changing the structure of the 'children' property added in #2947)