Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPROD-642] Eth events scanning #7

Merged
merged 41 commits into from
Feb 22, 2024
Merged

[EPROD-642] Eth events scanning #7

merged 41 commits into from
Feb 22, 2024

Conversation

F3kilo
Copy link
Contributor

@F3kilo F3kilo commented Dec 26, 2023

Issue ticket

Issue ticket link:
https://infinityswap.atlassian.net/browse/EPROD-642

Checklist before requesting a review

Code conventions

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@F3kilo F3kilo marked this pull request as ready for review February 7, 2024 10:33
@F3kilo F3kilo requested a review from veeso February 7, 2024 10:34
src/minter-contract-utils/src/bft_bridge_api.rs Outdated Show resolved Hide resolved
src/minter-contract-utils/src/bft_bridge_api.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/minter-contract-utils/build.rs Show resolved Hide resolved
src/minter-contract-utils/src/lib.rs Show resolved Hide resolved
src/evm-minter/src/state/config.rs Show resolved Hide resolved
@ufoscout
Copy link
Contributor

@F3kilo there are conflicts to be resolved

@F3kilo F3kilo requested a review from ufoscout February 16, 2024 09:53
@F3kilo F3kilo requested a review from ufoscout February 20, 2024 10:43
@F3kilo F3kilo marked this pull request as draft February 22, 2024 13:08
@blutooth blutooth marked this pull request as ready for review February 22, 2024 14:28
@blutooth blutooth merged commit bd50b20 into main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants