Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPROD-1064] FeeCharge without approved spenders #193

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

F3kilo
Copy link
Contributor

@F3kilo F3kilo commented Nov 7, 2024

Issue ticket

Issue ticket link:
https://infinityswap.atlassian.net/browse/EPROD-1064

Checklist before requesting a review

Code conventions

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@F3kilo F3kilo merged commit e846de5 into main Nov 14, 2024
1 check passed
@veeso veeso deleted the remove_approved_fee_spenders branch November 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants