Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BFT to BTF across the bridge modules for consistency #189

Merged
merged 12 commits into from
Nov 8, 2024

Conversation

itsyaasir
Copy link
Contributor

@itsyaasir itsyaasir commented Nov 5, 2024

Issue ticket

Issue ticket link:

Checklist before requesting a review

Code conventions

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@itsyaasir itsyaasir requested a review from veeso November 6, 2024 02:44
Copy link
Contributor

@Maximkaaa Maximkaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be renamed also:
image

solidity/script/UpgradeBFT.s.sol Outdated Show resolved Hide resolved
@Maximkaaa
Copy link
Contributor

Yeah, those files from my screenshot got in there after you did search and replace. Sorry :-)

@itsyaasir itsyaasir merged commit b2e9642 into main Nov 8, 2024
1 check passed
@itsyaasir itsyaasir deleted the EPROD-1048-rename-all-bft-instances-to-btf branch November 8, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants