Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPROD-1033] Deploy BFT contracts using forge #179

Merged

Conversation

itsyaasir
Copy link
Contributor

@itsyaasir itsyaasir commented Oct 16, 2024

Issue ticket

Issue ticket link:

Checklist before requesting a review

Code conventions

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@itsyaasir itsyaasir marked this pull request as ready for review October 17, 2024 14:24
just/dfx.just Outdated Show resolved Hide resolved
solidity/src/WrappedTokenDeployer.sol Outdated Show resolved Hide resolved
Deploy.md Outdated Show resolved Hide resolved
solidity/deploy.sh Outdated Show resolved Hide resolved
…t-of-the-scripts-from-hardhat-tasks-to-forge-scripts

[EPROD-1044] migrate rest of the scripts from hardhat tasks to forge scripts
@ufoscout ufoscout merged commit 33e44c2 into main Oct 22, 2024
1 check passed
@ufoscout ufoscout deleted the EPROD-1033-deploy-bft-contract-using-open-zeppelin-and-forge branch October 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants