Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPROD-1037] Remove icx-proxy #176

Merged
merged 8 commits into from
Oct 24, 2024
Merged

[EPROD-1037] Remove icx-proxy #176

merged 8 commits into from
Oct 24, 2024

Conversation

ufoscout
Copy link
Contributor

@ufoscout ufoscout commented Oct 9, 2024

Issue ticket

Issue ticket link:

Checklist before requesting a review

Code conventions

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@Maximkaaa
Copy link
Contributor

Hmmm.... If we remove icx-proxy, we cannot use hardhat to deploy contracts to a local EVM. It might be possible with forge, but I would say it's nice to have a simple way for existing EVM tooling to connect to a local EVM deployed in dfx IC. Is there a reason we want to remove this, or is it just for a cleanup?

@ufoscout
Copy link
Contributor Author

Hmmm.... If we remove icx-proxy, we cannot use hardhat to deploy contracts to a local EVM. It might be possible with forge, but I would say it's nice to have a simple way for existing EVM tooling to connect to a local EVM deployed in dfx IC. Is there a reason we want to remove this, or is it just for a cleanup?

@Maximkaaa There's no real advantage in removing it. However, the icx-proxy project is deprecated and the dfinity foundation advises not to use it anymore. Luckily, the latest dfx version contains a webserver that offers part of the icx-proxy features, this is enough for most of our needs. Nevertheless, before merging this PR, I will investigate with @itsyaasir whether the new webserver can be used for local deployment of the BftBridge with Hardhat or Forge.

@ufoscout ufoscout changed the base branch from main to EPROD-1038-add-deployer-tests October 24, 2024 08:52
Base automatically changed from EPROD-1038-add-deployer-tests to main October 24, 2024 10:31
@ufoscout ufoscout merged commit e0658f4 into main Oct 24, 2024
1 check passed
@ufoscout ufoscout deleted the EPROD-1037_remove_icx_proxy branch October 24, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants