Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(improvements) Tax report: improve UX during initial sync #888

Merged
merged 12 commits into from
Jan 16, 2025

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Dec 5, 2024

Tasks:
https://app.asana.com/0/1163495710802945/1208891975570895/f
https://app.asana.com/0/1163495710802945/1208892028698356/f

Description:

  • Renames Filter button to Generate and also disables it during the initial synchronization to prevent Tax Report generation errors
tax-init-sync-gen-err
  • Implements corresponding notice for the users during the initial sync
"Sync in progress. Please wait until it’s complete to generate your tax report."
  • Syncs staging with the latest master

Preview:

tax-init-sync-prev  
tax-init-sync-flow.mov

@alexstotsky alexstotsky changed the title Improve ux tax report (improvements) Tax report: improve UX during initial sync Dec 5, 2024
@alexstotsky alexstotsky marked this pull request as ready for review December 5, 2024 12:16
Copy link

@JasonMHasperhoven JasonMHasperhoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 1b5575a into bitfinexcom:staging Jan 16, 2025
@alexstotsky alexstotsky deleted the improve-ux-tax-report branch January 16, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants