Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload dist release if repo owner is customized #347

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Mar 14, 2024

This PR adds ability to upload a dist release if the repo owner is customized


The idea is the following:

  • have the ability to set custom repo owner for auto-update
  • it's useful for beta and main releases made against the forked repo
  • as the electron-builder does not support separate customization of repo owner for publishing and auto-update
  • if the custom repo owner is set
  • and its set value is different from the current actual repo owner
  • turn off the publishing feature of the electron-builder functionality
  • and then use actions/upload-artifact@v4 after being built to upload binaries to the Artifacts section of the Build release workflow like shown here https://github.com/ZIMkaRU/bfx-report-electron/actions/runs/8276698230

Screenshot from 2024-03-14 09-33-40

Screenshot from 2024-03-14 09-34-34

Screenshot from 2024-03-14 09-32-15

Screenshot from 2024-03-13 14-48-04

Screenshot from 2024-03-13 11-08-01

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 863f0d1 into bitfinexcom:staging Mar 15, 2024
This was referenced Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants