Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target frameworks #662

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update target frameworks #662

wants to merge 5 commits into from

Conversation

Joy-less
Copy link

This pull request removes unsupported target frameworks (.NET Core, .NET 6.0) and simplifies conditional compilation so it supports NETSTANDARD (.NET Standard 2.0) and NET (.NET 8.0 and .NET 9.0).

@bitfaster
Copy link
Owner

Wow, thanks!

I had started to look at this here #638, and planned to go back and effectively make your PR (so I would go in stages update fwks changes, then take each feature as a follow PR).

I think the gates will fail on your change, I just started a run - my other PR has fixes for that stuff in the build yaml files.

I will take a proper look at this on the weekend.

@Joy-less Joy-less mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitfaster bitfaster bitfaster left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joy-less @bitfaster