Skip to content

Commit

Permalink
Merge pull request #488 from bitdefender/ab-tests-fix
Browse files Browse the repository at this point in the history
fix: handle potential undefined content in target offer retrieval
  • Loading branch information
Matei-Iordache authored Jan 15, 2025
2 parents e6be9a0 + f91f7eb commit 6f16324
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions _src/scripts/libs/data-layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { UserAgent } from "./user-agent/index.js";
import { User } from "./user.js";
import Page from "./page.js";
import { Constants } from "./constants.js";
import { loadCSS } from "../lib-franklin.js";

/**
*
Expand Down Expand Up @@ -89,8 +90,13 @@ export class PageLoadStartedEvent {
const targetExperimentId = this.#getMetadata('target-experiment');
if (targetExperimentLocation && targetExperimentId && !shouldABTestsBeDisabled()) {
const { runTargetExperiment } = await import('../target.js');
const experimentUrl = (await Target.getOffer(targetExperimentLocation))?.content?.url;
targetExperimentDetails = await runTargetExperiment(experimentUrl, targetExperimentId);
const offer = await Target.getOffer(targetExperimentLocation);
const { url, template } = offer?.content || {};
if (template) {
loadCSS(`${window.hlx.codeBasePath}/scripts/template-factories/${template}.css`);
document.body.classList.add(template);
}
targetExperimentDetails = await runTargetExperiment(url, targetExperimentId);
}

return targetExperimentDetails;
Expand Down

0 comments on commit 6f16324

Please sign in to comment.