Feat/hybrid #13
Merged
Feat/hybrid #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
reviewed
Jun 26, 2024
tsconfig.json
Outdated
| "extends": "./tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "outDir": "src/esm", | ||
| "esModuleInterop": true, |
There was a problem hiding this comment.
esModuleInterop is only useful for commonjs
ESM does not need interop considerations with ESM.
There was a problem hiding this comment.
you're right..., will move it
junderw
reviewed
Jun 26, 2024
tsconfig.base.json
Outdated
Comment on lines
4
to
5
| "module": "commonjs", | ||
| "outDir": "./src", |
There was a problem hiding this comment.
module and outDir are both defined in the other configs. Not really needed.
|
Can you write a benchmark that compares all these DataView and ArrayBuffers to something simpler? I think we should add some bit writing functions in uint8array-tool and use those. But if DataView and ArrayBuffer are fast enough it might be fine. |
junderw
reviewed
Aug 11, 2024
src/esm/index.js
Outdated
| bytes: 5 | ||
| }; | ||
| // 64 bit | ||
| } | ||
| else { | ||
| const number = tools.readUInt64(buffer, offset + 1, 'LE'); | ||
| return { value: number, bytes: 9 }; | ||
| return { numberValue: null, bigintValue: number, bytes: 9 }; |
There was a problem hiding this comment.
if number is <= to Number.MAX_SAFE_INTEGER then return the numberValue.
junderw
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: