refactor: move tx_template from bdk_chain to bdk_testenv
#1800
Conversation
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
3 times, most recently
from
8b81584 to
12181bb
Compare
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
12181bb to
13b87ac
Compare
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
13b87ac to
dd47a8b
Compare
There was a problem hiding this comment.
Thanks for working on this one, so far it's looking good.
Please update the commit messages to follow conventional commits, i.e: `refactor: move `tx_template` from `bdk_chain` to `bdk_testenv`
crates/testenv/Cargo.toml
Outdated
|
|
||
| [dev-dependencies] | ||
| bdk_testenv = { path = "." } | ||
| rand = "0.8" |
There was a problem hiding this comment.
IIUC this dependency is currently being used only for tx_template mod, right?
As it's only available when miniscript feature is being used, it'd be best to make this one an optional dependency tied to that feature.
There was a problem hiding this comment.
yes, it is currently only being used in the tx_template mod.
crates/testenv/src/tx_template.rs
Outdated
| pub inputs: Vec<TxInTemplate>, | ||
| pub outputs: Vec<TxOutTemplate>, | ||
| pub anchors: Vec<A>, |
There was a problem hiding this comment.
@tvpeter Any reason/tradeoff on using Vec, instead of Cow<'_, Tx..>?
There was a problem hiding this comment.
Looking at it again, there is no trade-off. Thank you for the feedback. I will update it, as Cow seems more efficient.
- refactor tx_template struct and init_graph to use Cow pointer - move `tx_template` from `chain/tests/common` to `testenv/src` - update `chain/tests` files to use `tx_template` from `testenv` - update deps in `chain/cargo.toml` and `testenv/cargo.toml` - update imports in `testenv/src/lib.rs` - refactor canonical benchmarks in `chain/benches` to use tx_template [Ticket: 1754]
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
dd47a8b to
657ffd8
Compare
tvpeter
changed the title
tx_template from bdk_chain to bdk_testenv
Description
This PR implements the following changes:
TxTemplatefromcrates/chain/tests/common/mod.rstotestenv.init_graphfunction andTxTemplatestruct to useCowO(n)canonicalization algorithm #1670 using TxTemplatesCloses #1754
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing