Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Wallet APIs related to revealing and querying the wallet for addresses and indices #599

Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Oct 1, 2024

This PR adds a bunch of the little methods we found last week were missing from the Wallet APIs. They're all mostly one-liners so it was easy to tackle.

Changelog notice

Added:
  - Wallet::peek_address method [#599]
  - Wallet::next_derivation_index [#599]
  - Wallet::next_unused_address [#599]
  - Wallet::mark_used [#599]
  - Wallet::reveal_addresses_to [#599]
  - Wallet::list_unused_addresses [#599]

[#599]: https://github.com/bitcoindevkit/bdk-ffi/pull/599

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@rustaceanrob
Copy link
Contributor

LGTM

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a58599f

looking forward to using list_unused_addresses that’s a nice one, thanks for adding all of these

@thunderbiscuit thunderbiscuit merged commit a58599f into bitcoindevkit:master Oct 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants