Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for repository to add new wordlists #1395

Closed

Conversation

vladimirfomene
Copy link

Many wordlists were proposed here, but they were closed with the following note:

For now, the author(s) of BIP 39 have decided not to accept any further word lists into BIP 39 itself, and encourage adding new ones to the WLIPs repo here: https://github.com/p2w34/wlips

I have added the note to the BIP's wiki so that people will know where to open these PRs going forward.

@murchandamus
Copy link
Contributor

Hey @prusnak and @slush0, could you check whether this is still correct today and matches your intention for BIP39 wordlists?

@prusnak
Copy link
Contributor

prusnak commented Apr 27, 2024

No. My intention is not to support any wordlists except for the English one to maximize interoperability.

@jonatack
Copy link
Member

Thanks @prusnak. IIUC this should therefore be closed, and bip-0039/bip-0039-wordlists.md updated?

This was referenced Apr 30, 2024
@murchandamus
Copy link
Contributor

I’m closing this PR, because one of the authors declined this proposed change to their BIP.

@LecrisUT
Copy link

LecrisUT commented Oct 4, 2024

Sorry for messaging randomly on a closed PR, but I do not wish to expose my personal gmail address or register my email address to a public mailing list, I hope you understand.

When packaging tiny-bip39 for Fedora we came across an issue that the original license of the BIP39 word list is not defined here 1. We are going by the assumption that it is meant to be published under MIT based on python-mnemonic, but could someone clarify this? I don't know who to ping precisely, maybe @prusnak?

Footnotes

  1. My understanding is that the license is defined from BIP2 which requires a License field to be populated in the bip document, but this is missing for BIP39

@prusnak
Copy link
Contributor

prusnak commented Oct 4, 2024

When packaging tiny-bip39 for Fedora we came across an issue that the original license of the BIP39 word list is not defined here [^1]. We are going by the assumption that it is meant to be published under MIT based on python-mnemonic, but could someone clarify this? I don't know who to ping precisely, maybe @prusnak?

Correct. MIT License

@jonatack
Copy link
Member

jonatack commented Oct 4, 2024

When packaging tiny-bip39 for Fedora we came across an issue that the original license of the BIP39 word list is not defined here [^1]. We are going by the assumption that it is meant to be published under MIT based on python-mnemonic, but could someone clarify this? I don't know who to ping precisely, maybe @prusnak?

Correct. MIT License

Thanks @prusnak for the quick response. Would you like to open a pull to add the license to BIP39?

jonatack added a commit to jonatack/bips that referenced this pull request Oct 8, 2024
These are required per BIP-2, and they avoid user confusion as seen in

bitcoin#1395 (comment)
@jonatack
Copy link
Member

jonatack commented Oct 8, 2024

Correct. MIT License

Thanks @prusnak for the quick response. Would you like to open a pull to add the license to BIP39?

Proposed in #1680.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants