[WIP]: Add herecomesbitcoin animations #4254
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herecomesbitcoin-faq.mp4 |
thebrandonlucas
changed the title
|
Looking really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for adding herecomesbitcoin animations to bitcoin.org as mentioned in #4234. I started with the FAQ page, as seen below. I'm opening this as a draft PR because there are a few other animations we'd like to add, but I wanted to make sure that the code is being added the preferred way. I created an
animations/herecomesbitcoindirectory under_includesand am including the html files directly where they are needed. I also added an animation sectionscreens.scssfor styles pertaining to the animations. @Cobra-Bitcoin Please let me know if there is anything I should change about my method of adding animations before continuing to move forward. Thanks!