Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix namespace bug in _logs() #653

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

pinheadmz
Copy link
Contributor

There is a leftover bug from #651 that prevented the Battle signet miner command from working:

Command:

(.venv) --> warnet run scenarios/admin/signet_miner.py --source_dir=scenarios --tank=0 generate --min-nbits --address=$(warnet bitcoin rpc miner getnewaddress) --ongoing --debug

Error:

Error getting pods. Could not determine primary container: cannot access local variable 'pod_namespace' where it is not associated with a value

@mplsgrant
Copy link
Collaborator

mplsgrant commented Oct 15, 2024

ACK. Works for me.

edit The namespace component works for me, but the command in op does give me this error:

Waiting for commander pod to start...
/bin/sh: 1: Syntax error: "(" unexpected
Deleting pod...
pod "commander-signetminer-1729005660" deleted

update: I needed to create the wallet and have the miner tank up and running, and that allowed the command in op to run!

@pinheadmz pinheadmz merged commit 4586ddc into bitcoin-dev-project:main Oct 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants