chart: set rpcpassword as a value, add to labels for scenarios #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All worked for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configmap helm logic then adds the chart value to bitcoin.conf and to the pod metadata labels, same mechanism we currently use for rpcport. This allows chart-writers to override rpcpassword on an individual per-tank basis. When deploying a scenario, the metadata with the password is read from the metadata labels and written to warnet.json in the commander pod. Assuming namespaces limit users ability to read pod metadata, this should restrict rpc access to users in multiplayer mode.
I also changed the default password in the base chart values so if anything was hard coded we should see tests fail.
UPDATE: that was so smart of me, "password" was hard coded in the prometheus exporter