charts: split off defaultConfig from [node] config #622
Conversation
| @@ -187,7 +187,6 @@ def get_messages(tank_a: str, tank_b: str, chain: str): | |||
| file_path = f"{base_dir}/{dir_name}/{file}" | |||
| # Fetch the file contents from the container | |||
| cmd = f"kubectl exec {tank_a} -- cat {file_path}" | |||
| import subprocess | |||
There was a problem hiding this comment.
Wasn't there a reason this was in here?
There was a problem hiding this comment.
its up top now, i thought that might be what the linter was complaining about since it does not inform me, the guy trying to pass CI, what it was complaining about 🔥
|
I think we should probably include a config section in 6_node network as an example. |
doen! |
|
@m3dwards added a test! I upcycled your existing graph_test to deploy the network it creates and verify that |
|
ACK. Tested and config worked for me. |
The
configvalue could be set in bothnode-defaults.yamland innetwork.yamlwith the latter clobbering the default. This adds a second valuedefaultConfigwhich is concatenated withconfigso tanks can run bitcoin.conf settings from a combination of:baseConfigset in values.yaml (all nodes in every warnet)defaultConfigset in node-defaults.yaml (all nodes in your network)configset in network.yaml (per-node individual settings)