Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test_framework to v26.0 and add a miniwallet prop to test_node #296

Merged
merged 2 commits into from
Mar 4, 2024
Merged

update test_framework to v26.0 and add a miniwallet prop to test_node #296

merged 2 commits into from
Mar 4, 2024

Conversation

willcl-ark
Copy link
Contributor

@willcl-ark willcl-ark commented Mar 4, 2024 •
edited
Loading

This updates the test_framework to Bitcoin Core v26.0, which can be used in e.g. double_tx_relay tests.
Also add a miniwallet property to test_node.

@willcl-ark
Copy link
Contributor Author

@pinheadmz you want to check this before merge?

pinheadmz
pinheadmz approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Confirmed no diff when manually importing v26.0 test_framework except for addiiton of miniwallet in test base. CI is green, the trap is clean.

@willcl-ark willcl-ark merged commit ca08973 into bitcoin-dev-project:main Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinheadmz pinheadmz pinheadmz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Bitcoin Development Project Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willcl-ark @pinheadmz