include schema and templates in non-editable images #292
Conversation
willcl-ark
force-pushed
the
copy-node-schema
branch
from
dba969d
to
63f3cb3
Compare
willcl-ark
force-pushed
the
copy-node-schema
branch
from
63f3cb3
to
f58ed09
Compare
willcl-ark
changed the title
|
This also switches the RPC statefulset to use the WDYT @m3dwards @pinheadmz @josibake ? |
|
BTW I did test this PR (image tag 0.4/latest on dockerhub) using a digital ocean cluster and... it works for me (TM) |
| @@ -17,7 +17,7 @@ spec: | |||
| containers: | |||
| - name: warnet-rpc | |||
| imagePullPolicy: Always | |||
| image: bitcoindevproject/warnet-rpc:0.2 | |||
| image: bitcoindevproject/warnet-rpc:latest | |||
There was a problem hiding this comment.
Just a note to say that this means if we push semantic versioned images we will also need to push an image with the tag latest explicitly for this to work.
There was a problem hiding this comment.
and I see you have the option for that in the build script.
There was a problem hiding this comment.
My intention was that we could push any tag we like, and then optionally also specify it as latest? There is also a latest tag there now
|
Looks good to me. I especially like the .dockerignore. |
This means we can just use "latest" in warnet-rpc-statefulset.yaml
This is a footgun we can do without.
This is needed when installing using `pip install .` e.g. in the non-dev image being pushed to docker hub., otherwise non-python template files are missing from the images.
willcl-ark
force-pushed
the
copy-node-schema
branch
from
f58ed09
to
a5d4bb4
Compare
previously this relied on
pip install -e .style install, and was not being copied across in a regularpip install .Fix that by putting the schema in it's own package, and explicitly including that in
MANIFEST.in, along with other files needed fromtemplates/.