test: always kill warnet server #141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
willcl-ark
force-pushed
the
robust-test
branch
from
07cd277 to
d81d56b
Compare
willcl-ark
commented
Oct 6, 2023
willcl-ark
force-pushed
the
robust-test
branch
from
d81d56b to
b77148d
Compare
|
@pinheadmz FYI all tests passing now (just restarted to pass). I also covered both startup CLI/RPC commands, i.e. |
Currently, if a test fails warnet server might not be properly killed and so remain running. This is annoying for iteration; if the test fails we want everything gone ready to run again. Also only try to bring the network down if we first brought it up to avoid spurious error messages in the logs.
willcl-ark
force-pushed
the
robust-test
branch
from
b77148d to
5c19770
Compare
pinheadmz
reviewed
Oct 12, 2023
| # kill the server process by its PID if it still survives | ||
| if self.server: | ||
| print(f"killing server with pid {self.server.pid}") | ||
| os.killpg(os.getpgid(self.server.pid), signal.SIGTERM) |
There was a problem hiding this comment.
this looks to me like the most useful part of this PR, I dont really understand the need for the other changes. Why couldn't this emergency termination just be part of the original cleanup() in the exception handler (i.e. if warcli stop fails?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a test fails warnet server might not be properly killed and so remain running.
This is annoying for iteration; if the test fails we want everything gone ready to run again.
Also only try to bring the network down if we first brought it up.