cmake: Clean up coverage flags #1557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CMAKE_C_FLAGS_COVERAGE` is language-wide variable. These flags will be passed to all invocations of the compiler, including invocations that drive compiling and those that drive linking. Therefore, `--coverage` in the `CMAKE_*_LINKER_FLAGS_COVERAGE` variables is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CMAKE_C_FLAGS_COVERAGEis a language-wide variable. These flags will be passed to all invocations of the compiler, including invocations that drive compiling and those that drive linking.Therefore,
--coveragein theCMAKE_*_LINKER_FLAGS_COVERAGEvariables is redundant.Also this PR allows the user to override
CMAKE_C_FLAGS_COVERAGEby setting a cache variable in the command line.