Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header: Delete default Minisketch constructor #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheCharlatan
Copy link

I might be missing a reason for having the default constructor, but it is not used anywhere and trying to use one of its methods will cause a segfault.

It is not used and trying to use one of its methods will cause a
segfault.
@theuni
Copy link
Contributor

theuni commented Jun 12, 2024

Concept ACK. @TheCharlatan and I discussed this and couldn't find a user of the default ctor.

Barely any functions check for a valid m_minisketch before using it. So rather than adding the checks, we figured it made sense to just eliminate the possibility.

As far as I can see, without this ctor, the only way to hit a null m_minisketch would be a moved-from object, which is usually assumed to be undefined unless otherwise specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants