UI Only AU Snapshot Import Flow #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ack |
MarnixCroes
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Doesn't it make more sense to (also) have this part of the onboarding workflow?nvm, I think we shouldn't do this (maybe later)- Also, having it at
Connectionmenu would not be something where I would be looking at to find this feature. Maybe it needs anAdvancedsection? - A UI for an incorrect snapshot and/or failure of importing the snapshot is missing
| id: gotoSnapshot | ||
| Layout.fillWidth: true | ||
| header: qsTr("Import snapshot") | ||
| description: qsTr("Speed up the initial download") |
There was a problem hiding this comment.
as you said correctly in the import snapshot dialog, it doesn't speed up the download itself.
So this might be misleading.
I think it's better to rephrase it, something like this might be more appropriate Start using right away and do initial synchronization in the background or maybe something short like Do initial synchronization in the background
| @@ -0,0 +1,35 @@ | |||
| // Copyright (c) 2024 - PresentThe Bitcoin Core developers | |||
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2024 - PresentThe Bitcoin Core developers | |
| // Copyright (c) 2024-present The Bitcoin Core developers |
nit
and at other files you created it has 2023 instead of 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the UI flow to be able to import a AssumeUTXO (AU) snapshot into the Bitcoin Core App.
The user will be able to load an AU snapshot from the "Connection Settings" page as designed here
*This is a UI only commit no actual functionality has been coded. Wiring to actually import a AU snapshot will happen in a future PR
Ubuntu 22.04 Screenshots