Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scrollbar to wallet select list #416

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

MarnixCroes
Copy link
Contributor

This adds a scrollbar to the wallet selection list.

Addresses #401 (review)


Images

scrollbar visible on hover/when scrolling when having more wallets than that are initially visible
image

no scrollbar when not needed:
image

@MarnixCroes MarnixCroes changed the title qml: add scrollbar to wallet select list add scrollbar to wallet select list Aug 12, 2024
Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ba98b83

@hebasto
Copy link
Member

hebasto commented Sep 2, 2024

cc @GBKS

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ba98b83

This works fine testing on macOS and Linux.

@hebasto hebasto merged commit 84c4372 into bitcoin-core:main Sep 11, 2024
9 checks passed
@MarnixCroes MarnixCroes deleted the scrollbar-walletlist branch September 11, 2024 10:37
@GBKS
Copy link
Contributor

GBKS commented Sep 11, 2024

Sorry I didn't check on this earlier. Is it possible to align the scrollbar as shown in the designs, closer to the right edge?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants