Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set implicitHeight on InformationPage #352

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Set implicitHeight on InformationPage #352

merged 1 commit into from
Jul 12, 2023

Conversation

johnny9
Copy link
Contributor

@johnny9 johnny9 commented Jul 4, 2023 •
edited
Loading

Fixes the binding loop on the ScrollView's contentHeight

#339

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android
ARM32 Android

@johnny9
qml: set implicitHeight on InformationPage
5fde4fa 
Fixes the binding loop on the scrollView's contentHeight
@hebasto hebasto changed the title qml: set implicitHeight on InformationPage Set implicitHeight on InformationPage Jul 4, 2023
@jarolrod jarolrod added Bug Something isn't working Android labels Jul 4, 2023
jarolrod
jarolrod approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5fde4fa

Tested that there are no visual changes between master and pr on desktop and mobile. Confirm that it fixes the binding loop.

@hebasto hebasto merged commit d41dc18 into bitcoin-core:main Jul 12, 2023
@jarolrod jarolrod mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarolrod jarolrod jarolrod approved these changes

Assignees
No one assigned
Labels
Android Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnny9 @jarolrod @hebasto