Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: node-gyp dependency #286

Merged
merged 4 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed .deploy
Empty file.
4 changes: 2 additions & 2 deletions apps/webapp/lib/config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { getValidSmartsaleEnv, smartsaleEnv } from 'app-env'

const env = getValidSmartsaleEnv(process.env.NEXT_PUBLIC_APP_ENV || 'test')
const env = getValidSmartsaleEnv(process.env.NEXT_PUBLIC_APP_ENV || 'dev')

export const appConfig = {
env,
Expand Down Expand Up @@ -31,4 +31,4 @@ export const appConfig = {
}
} as const

console.log('🧑🏻‍💻 appConfig', appConfig)
// console.log('🧑🏻‍💻 appConfig', appConfig)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Commented out console.log statement.

If this console.log statement is no longer needed, consider removing it entirely to keep the codebase clean. If it might be needed for future debugging, it might be better to use a more sophisticated logging mechanism that can be toggled on or off based on the environment.

Suggested change
// console.log('🧑🏻‍💻 appConfig', appConfig)
if (process.env.NODE_ENV === 'development') {
console.log('🧑🏻‍💻 appConfig', appConfig);
}

3 changes: 2 additions & 1 deletion apps/webapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"format": "prettier --write \"{app,lib,components}/**/*.{ts,tsx,mdx}\" --cache",
"format:check": "prettier --check \"{app,lib,components}**/*.{ts,tsx,mdx}\" --cache",
"translate": "bun run scripts/translate.ts",
"translate:category": "bun run scripts/translate-category.ts"
"translate:category": "bun run scripts/translate-category.ts",
"vercel:install": "npm i -g node-gyp; bun install"
},
"dependencies": {
"@ai-sdk/anthropic": "^0.0.30",
Expand Down
Binary file modified bun.lockb
Binary file not shown.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading