Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource references not being loaded on exported builds (Godot 4.3) #189

Closed
wants to merge 3 commits into from

Conversation

shomykohai
Copy link
Contributor

@shomykohai shomykohai commented Jul 9, 2024

Description

On exported builds, it is not guaranteed that the get_default_value returns a Resource, even if we cast it.
In fact, in the editor they are treated as Resources, but on exported builds they are Strings.
This prevents casting a String as a Resource by calling load() if default_value is not a Resource.

Edit: The issue seem to be related to the same one as #187, the generated GDScript bytecode on exported builds.

Screenshots

Printing out default_value before this PR:
EDITOR:
Editor output
EXPORTED BUILD:
Exported build output

@shomykohai
Copy link
Contributor Author

Superseded by #197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant