Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds texture2d stub property #174

Open
wants to merge 1 commit into
base: godot-4.x
Choose a base branch
from

Conversation

imothee
Copy link
Contributor

@imothee imothee commented Feb 29, 2024

Description

Adds a texture2d property to Pandora that properly handles serializing AtlasTextures (since the default resource type requires a resource to exist on disk whereas this can re-use a spritesheet path and a region).

Addressed issues

Could not save AtlasTextures accurately.

Screenshots

Shows the added icon to the property bar
Screenshot 2024-02-29 at 1 44 28 PM

Shows the default dropdown resource picker
Screenshot 2024-02-29 at 1 44 46 PM

Shows dragging an existing Texture2D in from another template resource
Screenshot 2024-02-29 at 1 45 06 PM

@bitbrain
Copy link
Owner

@imothee any progress on this? The tests are failing. Btw, you only gotta support Godot 4.2 onwards, no need any longer to remain backwards compatible with Godot 4.0/4.1

@bitbrain bitbrain force-pushed the add-texture2d-property branch from 5430956 to b53c0f9 Compare June 29, 2024 09:19
@imothee
Copy link
Contributor Author

imothee commented Jul 8, 2024

I hadn't spent any time on this since I was waiting/chatting in the Godot discord about if/when they'd expose the texture selector to general scripting. I'm in Australia travelling so I'm a bit behind but I can take a look at this when I'm back home and see where things are

@bitbrain bitbrain force-pushed the add-texture2d-property branch from b53c0f9 to 2487ae1 Compare July 11, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants