-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vector property types #155
Conversation
added vector properties added vector properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkrisc tests seem to fail - make sure to check the logs for the errors. You also seem to have introduced a memory leak via stray nodes. Ensure to always free up nodes you instantiate via new() that are objects.
https://mikeschulze.github.io/gdUnit3/advanced_testing/orphan/
addons/pandora/ui/components/properties/vector/vector_property.gd
Outdated
Show resolved
Hide resolved
addons/pandora/ui/components/properties/vector/vector_property.gd
Outdated
Show resolved
Hide resolved
I believe the issues, including the stray nodes, are related to the fact I used the EditorSpinSlider node which fails to instantiate since the tests are not run in the editor and that particular control is only available in the editor itself. The only objects I directly create via I used this control since it's an editor plugin and to ensure consistency with vector input fields elsewhere in the editor. However, seems using that control is essentially untestable. So the options I see:
|
…o adhere to style. Replaced boolean operators and fixed brackets.
I replaced the EditorSpinSlider with a SpinBox to keep things simple for now and all tests pass on my end. I'll leave that as a possible future enhancement. I also realized I wasn't using GDUnit correctly initially and that's why I didn't catch it earlier - noob mistake. |
Thank you! |
Description
Added four new vector properties:
Added related getter and setter methods to PandoraEntity for each new property type.
Updated docs to reflect new properties.
Addressed issues
Screenshots