🐛 ensure saving scenes with instantiated entities works

bitbrain · Sep 22, 2023 · 724f09d · 724f09d
1 parent c8f7ab9
commit 724f09d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/addons/pandora/model/entity.gd b/addons/pandora/model/entity.gd
@@ -167,6 +167,8 @@ func init_entity(id:String, name:String, icon_path:String, category_id:String) -
 func instantiate() -> PandoraEntity:
 	var entity = ScriptUtil.create_entity_from_script(get_script_path(), "", "", "", "")
 	if entity != null:
+		# ensure to store the id on instances too, so scene saving does not break.
+		entity._id = get_entity_id()
 		entity._instanced_from_id = get_entity_id()
 	return entity
 

diff --git a/test/model/property_test.gd b/test/model/property_test.gd
@@ -144,4 +144,4 @@ func test_array_property_wrong_type() -> void:
 	property.set_default_value([1, 2, 3])
 	var new_property = PandoraProperty.new("", "", "")
 	new_property.load_data(property.save_data())
-	assert_that(new_property.get_default_value()).is_equal("")
+	assert_that(new_property.get_default_value()).is_equal("")