Add spport to PHP 7.3

bissolli · Jun 15, 2019 · a7b98a9 · a7b98a9
1 parent e28f895
commit a7b98a9
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 70 deletions.
diff --git a/composer.json b/composer.json
@@ -13,8 +13,8 @@
     ],
     "require": {
         "php": ">=7.1.0",
-        "paquettg/php-html-parser": "^1.7",
-        "nesbot/carbon": "~1.32"
+        "nesbot/carbon": "~1.32",
+        "paquettg/php-html-parser": "^2.0"
     },
     "require-dev": {
         "phpunit/phpunit": "~5.5"

diff --git a/composer.lock b/composer.lock
diff --git a/src/Twitter.php b/src/Twitter.php
@@ -76,7 +76,7 @@ public function loadTweets()
                 Tweet::create([
                     'id' => $tweet->{'data-tweet-id'},
                     'username' => $tweet->{'data-screen-name'},
-                    'is_retweet' => count($tweet->find('.js-retweet-text')[0]) > 0,
+                    'is_retweet' => !is_null($tweet->find('.js-retweet-text')[0]),
                     'content' => $this->sanitizeNodeText($tweet->find('.tweet-text')[0]),
                     'created_at' => Carbon::createFromTimestampMs($this->sanitizeNodeAttr($tweet->find('.tweet-timestamp span')[0], 'data-time-ms')),
                     'replies_count' => $this->countAttr($tweet->find('.ProfileTweet-action--reply .ProfileTweet-actionCount'), 'data-tweet-stat-count'),