Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2634/simple html node monitor #3000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bsc7
Copy link
Contributor

@bsc7 bsc7 commented Nov 13, 2024

NodeMonitor: FE: +ReportDiffs, +NodeType/UserName

  • ReportDiffs: Compares reports and highlights deviations based on thresholds.
  • NodeType/UserName: Displays node type and username alongside the address.
  • Unified BE/FE naming conventions and API endpoints for consistency.

ReportDiffs enables comparison across all reports and provides average values. It supports three configurable thresholds, which can be adjusted in the settings. Threshold violations are visually highlighted, hover shows the specific average value and the amount by which it was exceeded. For subtables, the background of the button that toggles the detail view is marked based on the highest exceeded threshold.

Origin: #2634, Previous PR: #2978

* Display node type and username alongside address.
* Unified BE/FE naming conventions and API endpoints for consistency.
* ReportDiffs: Compares reports and highlights deviations based on thresholds.
* NodeType/UserName: Displays node type and username alongside the address.
* Unified BE/FE naming conventions and API endpoints for consistency.

---
ReportDiffs enables comparison across all reports and provides average values. It supports three configurable thresholds, which can be adjusted in the settings. Threshold violations are visually highlighted: for subtables, the background of the button that toggles the detail view is marked based on the highest exceeded threshold.
@bsc7
Copy link
Contributor Author

bsc7 commented Nov 14, 2024

Bildschirmfoto vom 2024-11-13 15-12-50
Bildschirmfoto vom 2024-11-13 15-13-30

@HenrikJannsen
Copy link
Contributor

Looks great!

Could we change the algorithm for coloring for certain fields?

  • Num Connections: Don't apply color if >10. Nodes can configure target number but should be min. 12
  • Memory Used: Don't apply if < 500
  • Num Threads: Don't apply if < 70
  • Node Load: Don't apply if < 0.4

Let me know if you can do that in this PR or prefer a new one.

@bsc7
Copy link
Contributor Author

bsc7 commented Nov 15, 2024

I'll take care of it in this PR; it shouldn't be a big deal. I just don't know if I'll get around to it in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants