Use taker's burning man selection height #7395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If trader A's block height is 134 his burning man selection height is 120, and if trader B's block height is 135 his burning man selection height is 130. The current burning man selection height verification code doesn't handle these edge-cases.
When a taker takes a trade he sends his burning man selection height to the maker. After validating the taker's burning man selection height, he has to use the taker's burning man selection height to verify the taker's delayed payout transaction because the maker's and taker's burning man selection height could be different. The current implementation uses the maker's burning man selection height. This can cause failed trades. Relates to bisq-network#7393.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a taker takes a trade he sends his burning man selection height to
the maker. After validating the taker's burning man selection height, he
has to use the taker's burning man selection height to verify the
taker's delayed payout transaction because the maker's and taker's
burning man selection height could be different. The current
implementation uses the maker's burning man selection height. This can
cause failed trades.
Relates to #7393.