fix: remove unnecessary coin usage

[thecockatiel]

It seems to be unnecessary
if it's not, can you explain, so we can add a comment for it ?

[HenrikJannsen]

utACK

[alvasw]

It looks like the developer wanted to handle unsigned integers correctly because the protobuf definition of AccountingTxOutput.value is a uint32 (unsigned integer) [1]. Java doesn't natively support unsigned integer and therefore we need to use the datatype long. Before persisting the data we need to convert the long back to an unsigned integer. The conversion is wrong here but it doesn't cause any bugs in this case.

2147483647 equals to Coin.valueOf(2147483647).getValue(). Could you please replace 2147483647 with Integer.MAX_VALUE and change the second argument to "We only support integer values in protobuf storage for the amount." to make the code more readable? Thank you!

[1]

bisq/proto/src/main/proto/pb.proto

Line 2032 in 631d0f9

uint32 value = 1;