Allow mediated payout signature message to be re-sent #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently with the tor DDoS attack, there has been a significant uptick in the number of mediation proposals that could not be accepted because one signing participant's trade signature message did not get through. The app prevents any re-try of sending the message as it is coded to assume reliable delivery.
This caused the mediators to do a lot more manual payouts (v. time consuming), and as such they are asking for the ability for users to re-send the dispute payout signature message.
Testing shows that removal of the gating, allowing the message to be resent, is an acceptable solution.